[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [microblaze-uclinux] [patch] memory management initialisation cleanup



Hi John,

At Mon, 02 Aug 2004 12:18:27 +1000,
John Williams wrote:
> 
> Hey Yashi,
> 
> Yasushi SHOJI wrote:
[...]
> > IMHO, we need to provide __pa() __va() family macro for seemless
> > integration for arch independent code.  but we should keep
> > arch/microblaze/* as clean as we can.
> 
> Not quite sure what you mean here - __pa() and __va() macros are already 
> defined for microblaze in asm-microblaze/page.h  They just reduce to 
> identity functions of course since physical == virtual for nommu system.

oops that was bad example.  I just wanted to say that, because we only
have physical address in microblaze right now, we don't need to use
__phys_to_virt() and friends in arch/microblaze/*.

# if we get mmu, we'll call it macroblaze so no need to worry, right? ;p

> > or, we can keep arch/microblaze/mm/* code in sync with arm so that we
> > can play with other fun stuff ;p
> > 
> > any plan in your mind, John?
> 
> Well, our research agenda here basically requires discontigmem, and from 
> a quick look armnommu seemed the only no-mmu target with clean support 
> (indeed /any/ support).  So, I'm not committed to tracking arm as such, 
> but rather just providing the functionality.
> 
> This arch-specific mem mgmt stuff changes so rarely, so I don't think we 
> need to achieve patch-level compatibility with armnommu or any other 
> target.  Common architectural roots should be enough to do what we need.

thanks for clearing.  I totally agree.

[...]
> > we need to modify a few line to tell the kernel how
> > many banks we have on each platform.
> 
> I'm picturing a function that goes in {mbvanilla|suzaku}.c, which builds 
> a meminfo struct that describes that platforms memory architecture. 
> Then the common code in kernel/setup.c passes this off to bootmem_init() 
> and paging_init().

ok.

> Anyway I'll apply the first patch now - it should be ready for cvs 
> updates shortly.

I just sync'ed with cvs and compiling...

best,
--
                 yashi
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@itee.uq.edu.au
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/