Re: [microblaze-uclinux] current CVS is broken for suzaku

[John Williams <jwilliams@xxxxxxxxxxxxxx>]

Hi Yashi,

Yasushi SHOJI wrote:
> At Wed, 03 Nov 2004 08:05:10 +1000,
> John Williams wrote:
> [...]
> 
>>>Suzaku doesn't have second uart but auto-config.in defines it.  that
>>>cause network chip not to able to acquire irq; which is taken by
>>>unpresent second uart.
>>
> well, thing is that suzaku's config is already broken from start.  we
> have illegally been using mbvanilla's xparamters.h for suzaku.  that
> just surfaced by the restructure.

Ah ok.  It exactly that sort of nastiness the new platform structure 
should prevent :)

Do you see the file arch/microblaze/platform/uclinux-auto/auto-config.in?

This is an autogenerated file, we'll be releasing the tools for that as 
soon as I can do some more testing.  It means the end of hand-configured 
linux kernels for microblaze :)  More on this next week.

For testing new suzaku platform, you can just copy this and edit as you 
need to - the naming system etc is pretty obvious.

>>>John, do you want me to define platform for suzaku so that I can just
>>>put whatever suzaku need to arch/microblaze/platform/suzaku/, or wait
>>>till restructure is done?
>>
>>Well I would certainly encourage you to move towards the /platform/xxx 
>>approach, but I really tried to maintain backwards compatability..
>>
>>Short term fix will be an #ifdef conditional on Suzaku in 
>>include/asm-microblaze/autoconfig.h - but a better solution will be 
>>create your own /platform/suzaku subdir.  Just use platform/uclinux-auto 
>>as a template.
> 
> Ok, I'll leave it for homework for now ;P
> 
> attached patch _hide_ the bug.  this is not the proper fix, but for
> now it works (tm).  John, can you apply attached patch for me?
> 

Applied (or at least queued - cvs.uclinux.org RSA keys have changed, I'm 
waiting to confirm it's legitimate!)

> anyway, let me ask a few q's.
> 
> - if I want to create new platform, I'll do in Board.mk
> 
> ifdef CONFIG_SUZAKU
> PLATFORM := suzaku
> endif

Yes.

> and I should _not_ define CONFIG_UCLINUX_AUTO, no?

Yes, sounds right.  Changes you propose below then become necessary 
(testing #ifdef PLATFORM vs #ifdef CONFIG_UCLINUX_AUTO)

> - since we are moving away from xparameters.h, I should not use
> include/asm-microblaze/xparameters.h in anyway.  is this right?

That's correct.  xparameters.h is dead, long live xparameters.h! :)

> - if so, top of include/asm-microblaze/xparameters.h's ifdef doesn't
> prevent accidental inclusion
> 
> #ifdef CONFIG_MICROBLAZE_AUTO_CONFIG
> #error Autoconfig-targets must not include xparameters.h
> #endif
> 
> this should be changed to
> 
> #ifdef PLATFORM
> #error New platform must not include xparameters.h
> #endif
> 
> no?

Sounds good.

> and this is also true for include/asm-microblaze/autoconfig.h since we
> don't need to map new style to old

Sounds reasonable.

>>Sorry for the breakage :(
> 
> 
> that's ok.  I just need to know the semantics behind it.  we'll do a
> few minor tweek on the way. :)

I'm sure the process of platformising Suzaku will bring out things I 
didn't consider when I did the new target.  This is good :)

Cheers,

John
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@itee.uq.edu.au
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/