Re: [microblaze-uclinux] Xilinx Ethernet Adapter Patch

[Paul Hartke <phartke@xxxxxxxxxxxx>]

Good point on spurious messages.  dev.c:dev_set_promiscuity() already prints
out a message only when something interesting has happened.  The whole
printk() should be removed.  It is interesting to see how many times this
function is called by the kernel internals when it is not doing any useful
work.  I guess there is a lot of that deep down in the guts.

Hooking up MII to MII in fixed full duplex mode works just fine in the
hardware--just a hassle when the adapter is written to assume a PHY.  There
is no magic and I've seen it done before but, yes, it is somewhat tricky.

Thanks.
Paul

Quoting John Williams <jwilliams@xxxxxxxxxxxxxx>:
> Hi Paul,
>
> Paul Hartke wrote:
>
> > It attempts to do three things:
> > 1) Limit the number of command line Ethernet MAC addresses to the
> number
> > actually configured in this kernel.
>
> Looks ok
>
> > 2) Enables setting/disabling Pomiscuous mode.
>
> This is pretty noisy - every time ifconfig does anything to the
> interface, we get a kernel log message telling us about promiscuous
> mode.  Did you take this bit straight from recent mvista sources?
> I wonder if it might be made a bit quiter - e.g. only notify on a change
> of state, rather than every time?
>
> > 3) Disables the Ethernet MAC from inserting/overwriting the MAC source
> > address on outgoing frames.  As far as I can tell, this is the normal
> Linux
> > behavior so I believe this is an oversight from the original Montavista
> > code.  Required for Linux to act as an Ethernet bridge/switch/hub.
>
> This seems fine (at least doesn't seem to break anything!).
>
> Have a think about the promiscuous stuff, if you can make a it a little
> quieter that would be good.
>
> > The target hardware design has two EMACs directly connected without any
> > intervening PHYs.  I am working on the adapter changes required to
> ignore
> > the PHY and directly communicate with another MAC.  That's more
> involved so
> > wanted to separate out these more limited mods for the community to
> > evaluate.
>
> Sounds tricky - wiring the MII interfaces together?
>
> John
>
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/