[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [microblaze-uclinux] Another ethernet patch for usbnet.c



Hello,

if you take a look at the 2.6 kernel driver for usbnet the alignment is
valid for every platform. So the modification shouldn't have any bad impact
on other platforms. On the contrary I think it's the right way to do it
especially on processors which have problems with unaligned accesses.

John Williams <jwilliams@xxxxxxxxxxxxxx> wrote:
> Hi Johan,
> 
> Dr. Johann Pfefferl wrote:
> 
> >if you want to use an USB Ethernet Bridge (for example D-Link DUB-E100)
> >in conjunction with a microblaze processor you have to apply the
> >following patch to get the usbnet driver working correctly. The problem
> >here is that the TCP header must be accessed 32 bit aligned on
> >microblaze. Otherwise the TCP stack doesn't work.
> 
> Thanks for the patch.  Since this touches mainline code, and will 
> therefore have impact on non-MicroBlaze architectures, it will need to 
> be made at least conditional on #defined(__microblaze__) or similar, if 
> I am to apply it to CVS.
> 
> If you can resubmit the patch in that form I'll cc: it to the 
> uclinux-dev list before committing.
> 
> Thanks,
> 
> John
> ___________________________
> microblaze-uclinux mailing list
> microblaze-uclinux@xxxxxxxxxxxxxx
> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive : 
> http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/

-- 
Dr. Johann Pfefferl   ------------   mailto j.pfefferl at eubus dot net
Eubus GmbH            http://www.eubus.net +++++ http://www.hydraxc.com
Phone: +49 (0)89 45 22 578-67
Fax:   +49 (0)89 45 22 578-55
==
 -o)   A computer program does what you tell it to do,
 /\\        not what you want it to do.               
_\_v-                                                 
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/