[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [microblaze-uclinux] xilinx_gpio driver patch




-----Original Message-----
From: owner-microblaze-uclinux@xxxxxxxxxxxxxx
[mailto:owner-microblaze-uclinux@xxxxxxxxxxxxxx] On Behalf Of John Williams
Sent: Wednesday, August 01, 2007 6:25 PM
To: microblaze-uclinux@xxxxxxxxxxxxxx
Subject: Re: [microblaze-uclinux] xilinx_gpio driver patch
Hello John, 

>Hi Jeff,

>Jeff Fellin wrote:

>> After some digging this morning, I know why call to request_irq() failed.
My
>> system configuration has the second GPIO using IRQ 12, which is what was
>> used in the Linux-2.4 version of the system. request_irq() fails the
request
>> if the requested IRQ is > the maximum supported IRQ, defined in
>> include/asm-microblaze/irq.h has 11. So 12 is greater than 11 and fails.
I
>> checked the code in the linux-2.4.x tree and the maximum irq value for a
>> microblaze system is 32. Hence why it worked in 2.4 and not in 2.6. The
>> question is should asm-microblaze/irq.h have NR_IRQ's changed to 32?

>NUM_IRQS is defined as CONFIG_XILINX_INTC0_0_NUM_INTR_INPUTS, which is 
>derived automatically via Kconfig.auto

>For example, if NUM_INTR_INPUTS is 5, the max IRQ registered should be 4.

>Can you cross check these values in your config?

Yes, my Kconfig's CONFIG_XILINX_INTC0_0_NUM_INTR_INPUTS had an incorrect
value. Thank you for pointing where all the pieces hide.

John
___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive :
http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/

___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/