[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [microblaze-uclinux] xenet_FifoSend(struct sk_buff *orig_skb,structnet_device*dev)



Hi again,

I kept the meaning of the parameters identical, even though they are now more constrained (parm1 must be equal to parm2 + 2, parm2 must be word aligned).

I just placed the assly_movhalf.S file in arch/microblaze/lib and mod'd the Makefile to build it, then changed the one line in drivers/net/xilinx_enet/adapter.c as noted. No other (new) changes. I do have the assembler do_csum and memcpy active in my build at the moment.

As my system is working, I'm not really able to debug a lot <G>.

When testing the assembler memcpy, I wrote a C wrapper function that called the assembler version (temp renamed as amemcpy) and did a byte-by-byte check of the copy results, giving me a summary of the call and failure when the results weren't as expected. Perhaps that's a quick way to check out what's happening for you?

Jim


----- Original Message ----- From: "Brettschneider Falk" <fbrettschneider@xxxxxxxxxxxxxxx>
To: <microblaze-uclinux@xxxxxxxxxxxxxx>
Sent: Wednesday, April 30, 2008 10:45 AM
Subject: RE: [microblaze-uclinux] xenet_FifoSend(struct sk_buff *orig_skb,structnet_device*dev)


Hi,

Jim Law wrote:
Here's a real one - I tested it this time then built it into
the kernel
Thanks!

it seems to work after replacing the call to memmove() with a call to
move_halfword_higher() in FifoRecvHandler() in
drivers/net/xilinx_enet/adapter.c.
Should I just replace string memmove by move_halfword_higher? Or have you changed the meaning of the 3 parameters, too? Anyway after replacing the function name, my network is broken. Seems to have a bug still...


You had mentioned drivers/net/xilinx_emac/adapter.c in your
previous email,
but my uClinux-2.4.x doesn't seem to have that directory.  I
am not using
the emaclite, although I assume there is a similar place
there that this new
function might be useful.
I have kernel 2.6 of last MMUless-PetaLinux.

CU, Falk

___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/


___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/