Re: [microblaze-uclinux] [PATCH] xilinx: Fix Microblaze dma_map_sg bug

[John Williams <john.williams@xxxxxxxxxxxxx>]

Hi Steve,

On Fri, May 29, 2009 at 12:22 AM, Steven J. Magnani
<steve@xxxxxxxxxxxxxxx> wrote:
> On Tue, 2009-05-26 at 22:58 +0800, Thomas Chou wrote:
>> > -           sg[i].dma_address = page_to_bus(sg_page(sg)) + sg->offset;
>> > +           sg->dma_address = page_to_bus(sg_page(sg)) + sg->offset;
>> >             virt = page_address(sg_page(sg)) + sg->offset;
>> >
>> sg->dma_address = sg_phys(sg);
>> virt = sg_virt(sg);
>>
>> There are accessors defined in include/linux/scatterlist.h .
>
> Even better, thanks for the tip.
>
> A little birdie told me that Xilinx is not actively maintaining the
> particular GIT tree on their website so it doesn't look like this patch
> will go anywhere. I'll update my local copy though.

No little birdies required - while PetaLogix are in active kernel
development mode (funded by Xilinx BTW), it doesn't make sense for
Xilinx to be pushing stuff into their MicroBlaze git tree, which are
soon to become basically mirrors of ours, plus any extra bits and
pieces they want to push out (drivers, board packages etc).  And, soon
after that, upstream will be the place, and we'll all be pulling from
there and just pushing the small stuff up.

Basically things are in a great state of flux at the moment as we push
to mainline, and we are confident that the kernel and tools will all
drop nicely into place in the next two months or so.

We'll hold onto your DMA patch, when the dust settles on the big
mmu/nommu merge that we're pushing for the 2.6.31 merge window, we can
start to add these little bits and pieces as well.

Your bug fixes and code review are valued and appreciated!

Cheers,

John
>
> Steve
>
>>
>> - Thomas
>> ___________________________
>> microblaze-uclinux mailing list
>> microblaze-uclinux@xxxxxxxxxxxxxx
>> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
>> Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
>>
>>
>
>
> ___________________________
> microblaze-uclinux mailing list
> microblaze-uclinux@xxxxxxxxxxxxxx
> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
>
>



-- 
John Williams, PhD, B.Eng, B.IT
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com  p: +61-7-30090663  f: +61-7-30090663

___________________________
microblaze-uclinux mailing list
microblaze-uclinux@xxxxxxxxxxxxxx
Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/